Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zks_l1_chain_id not returning int type #67

Merged

Conversation

comilao
Copy link
Contributor

@comilao comilao commented Apr 24, 2024

What πŸ’»

zks_l1_chain_id is not returning int, it's returning the hex string

Why βœ‹

  • Reason why first thing was added to PR
  • Reason why second thing was added to PR
  • Reason why third thing was added to PR

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes πŸ“

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@comilao comilao requested a review from a team as a code owner April 24, 2024 13:48
@petarTxFusion petarTxFusion merged commit 0ebd1b8 into zksync-sdk:master Apr 24, 2024
4 checks passed
@comilao comilao deleted the fix/zks-l1-chain-id-not-returning-int branch April 25, 2024 14:22
Copy link

github-actions bot commented Jun 7, 2024

πŸŽ‰ This PR is included in version 1.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Copy link

github-actions bot commented Jun 7, 2024

πŸŽ‰ This PR is included in version 1.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants